Skip to content

SAN-4053 - User Engagement Tracking#440

Merged
anandkumarpatel merged 3 commits intomasterfrom
SAN-4053-user-tracking
Apr 28, 2016
Merged

SAN-4053 - User Engagement Tracking#440
anandkumarpatel merged 3 commits intomasterfrom
SAN-4053-user-tracking

Conversation

@Myztiq
Copy link
Copy Markdown

@Myztiq Myztiq commented Apr 26, 2016

  • I added intercom env vars for navi.

Reviewers

Tests

Test any modifications on one of our environments.

  • tested on environment by someone

Deployment (post-merge)

Ensure that all environments have the given changes.

  • deployed to epsilon
  • deployed to gamma
  • deployed to delta

@rsandor
Copy link
Copy Markdown
Contributor

rsandor commented Apr 27, 2016

Yus. 💯

Comment thread ansible/group_vars/alpha-navi.yml Outdated
-e REDIS_CACERT={{ redis_ca_cert_path }}
-e REDIS_IPADDRESS={{ redis_host_address }}
-e REDIS_PORT={{ redis_tls_port }}
-e INTERCOM_APP_ID = {{ navi_intercom_app_id | default('undefined') }}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this to be undefined string? or just unset

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could have them be unset. How do I do that?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@anandkumarpatel anandkumarpatel merged commit bf085e8 into master Apr 28, 2016
@anandkumarpatel anandkumarpatel deleted the SAN-4053-user-tracking branch April 28, 2016 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants